linux-kernel - Re: [PATCH] tof: Add VL53L4CX TOF drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYiL89Lx9r8tJT0K@smile.fi.intel.com>
Date: Sun, 8 Feb 2026 15:13:23 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: 434779359@...com, David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Linus Walleij <linusw@...nel.org>,
	Bartosz Golaszewski <brgl@...nel.org>,
	liufulin <frank.liu@...ot.com>,
	Waqar Hameed <waqar.hameed@...s.com>, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers

On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote:
> On Sat,  7 Feb 2026 17:42:35 +0800
> 434779359@...com wrote:

> > This patch adds support for the vl53l4cx tof ic
> > ICs used in Qualcomm reference designs
> > 
> > Signed-off-by: liufulin <frank.liu@...ot.com>
> Hi Frank and welcome to IIO.
> 
> This is a massive commit.  Normally roughly speaking each commit should
> be an absolute maximum of 500-1000 lines of code because this what
> people can realistically review in one go.
> 
> I'll take a superficial look at what you have here but to make any
> progress towards upstream it will need stripping back to a much more
> minimalist base.  From that we we can then look at adding more features
> in future patch sets.
> 
> Note the largest drivers for what I'd expect to be a lot more complex
> than a time of flight sensor are not as large as this in terms of
> lines of code.

Yeah, this is even barely satisfies requirement to put into staging/iio.
It has so-o-o many style issues and other small things (I just pressed PgDn
several times within 5 seconds). You need to take your time and invest into:
- creating an upstream plan (roadmap)
- as Jonathan said, start with a minimalistic setup (not more than a couple of
  thousands of LoCs
- be sure the style follows the Coding Style and IIO subsystem specifics
- be sure the code uses modern APIs from kernel and not some outdated stuff

...

> For the full series, stay under 2000 lines or in practice it won't get
> reviewed.

Fun fact, I answered above without looking at the rest of the message.


-- 
With Best Regards,
Andy Shevchenko