linux-kernel - Re: [PATCH] tof: Add VL53L4CX TOF drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pnda4xj1884.a.out@axis.com>
Date: Sun, 8 Feb 2026 18:00:11 +0100
From: Waqar Hameed <waqar.hameed@...s.com>
To: <434779359@...com>
CC: Jonathan Cameron <jic23@...nel.org>, David Lechner
	<dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>, Linus Walleij <linusw@...nel.org>, "Bartosz
 Golaszewski" <brgl@...nel.org>, liufulin <frank.liu@...ot.com>,
	<linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
	<linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers

On Sat, Feb 07, 2026 at 17:42 +0800 434779359@...com wrote:

> From: liufulin <frank.liu@...ot.com>
>
> This patch adds support for the vl53l4cx tof ic
> ICs used in Qualcomm reference designs
>
> Signed-off-by: liufulin <frank.liu@...ot.com>

[...]

Many of my initial comments have already been stated by Jonathan and
Andy. I still want to emphasize to run `scripts/checkpatch.pl` on your
patches (this one has 6761 errors and 11804 warnings...) before sending
them. (Shouldn't we have CI jobs for this?).

Some other general comments: please include a description of the device
and the chosen driver design. The linked datasheet doesn't explain all
the functionality used in this driver ([1] mentions some "host API"?).
Moreover, it seems like this driver is not originally written by you (by
looking at the copyright headers) and thus has some history that might
need some explanation?

[1] ch 3, p. 6, https://www.st.com/resource/en/datasheet/vl53l0x.pdf