linux-kernel - Re: [PATCH v1] perf test record.sh: Fix shellcheck warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYidT9oKKB9LVvw6@x1>
Date: Sun, 8 Feb 2026 11:27:27 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>,
	Thomas Richter <tmricht@...ux.ibm.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf test record.sh: Fix shellcheck warning

On Sat, Feb 07, 2026 at 03:04:52PM -0800, Ian Rogers wrote:
> Add quotes to avoid the following warning:
> ```
> In tests/shell/record.sh line 264:
>  [ $(uname -m) = "s390x" ] && {
>    ^---------^ SC2046 (warning): Quote this to prevent word splitting.
> 
> For more information:
>  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
> ```
> 
> Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")

Thanks, applied to perf-tools-next,

- Arnaldo
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/shell/record.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 46b96d565680..7cb81cf3444a 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -261,7 +261,7 @@ test_uid() {
>  test_leader_sampling() {
>    echo "Basic leader sampling test"
>    events="{cycles,cycles}:Su"
> -  [ $(uname -m) = "s390x" ] && {
> +  [ "$(uname -m)" = "s390x" ] && {
>      [ ! -d /sys/devices/cpum_sf ] && {
>        echo "No CPUMF [Skipped record]"
>        return
> -- 
> 2.53.0.239.g8d8fc8a987-goog
>