linux-kernel - Re: [PATCH v1] perf test parse-metric: Ensure aggregate counts appear to have run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYidsNiGztDlfJeh@x1>
Date: Sun, 8 Feb 2026 11:29:04 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: ctshao@...gle.com, namhyung@...nel.org, adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com, james.clark@...aro.org,
	jolsa@...nel.org, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, mingo@...hat.com,
	peterz@...radead.org, yang.lee@...ux.alibaba.com
Subject: Re: [PATCH v1] perf test parse-metric: Ensure aggregate counts
 appear to have run

On Sat, Feb 07, 2026 at 09:54:55PM -0800, Ian Rogers wrote:
> Commit bb5a920b9099 ("perf stat: Ensure metrics are displayed even
> with failed events") made it so that counters which weren't enabled in
> the kernel were handled as NaN in metrics. This cased the "Parse and
> process metrics" test to start failing as it wasn't putting a non-zero
> value in these variables. Add arbitrary values of 1 to fix the test.
> 
> Fixes: bb5a920b9099 ("perf stat: Ensure metrics are displayed even with failed events")

Thanks, applied to perf-tools-next,

- Arnaldo
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/parse-metric.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c
> index 6bbc209a5c6a..7c7f489a5eb0 100644
> --- a/tools/perf/tests/parse-metric.c
> +++ b/tools/perf/tests/parse-metric.c
> @@ -41,6 +41,8 @@ static void load_runtime_stat(struct evlist *evlist, struct value *vals)
>  		count = find_value(evsel->name, vals);
>  		evsel->supported = true;
>  		evsel->stats->aggr->counts.val = count;
> +		evsel->stats->aggr->counts.ena = 1;
> +		evsel->stats->aggr->counts.run = 1;
>  	}
>  }
>  
> -- 
> 2.53.0.239.g8d8fc8a987-goog