linux-kernel - Re: [PATCH v2 next 06/11] tools/nolibc/printf: Use bit-masks to hold requested flag, length and conversion chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYiqM3dRMtf71zmd@1wt.eu>
Date: Sun, 8 Feb 2026 16:22:27 +0100
From: Willy Tarreau <w@....eu>
To: david.laight.linux@...il.com
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
        linux-kernel@...r.kernel.org, Cheng Li <lechain@...il.com>
Subject: Re: [PATCH v2 next 06/11] tools/nolibc/printf: Use bit-masks to hold
 requested flag, length and conversion chars

On Fri, Feb 06, 2026 at 07:11:16PM +0000, david.laight.linux@...il.com wrote:
> From: David Laight <david.laight.linux@...il.com>
> 
> Use flags bits (1u << (ch & 31)) for the flags, length modifiers, and
> conversion specifiers.
> This makes it easy to test for multiple values at once.
> 
> Detect the conversion flags " #+-0" although they are currently all ignored.
> 
> Add support for length modifiers 't' and 'z' (both long) and 'q' and 'L'
> (both long long).
> 
> Add support for "%i" (the same as %d").
> 
> Unconditionally generate the signed values (for %d) to remove a second
> set of checks for the size.

OK, looks good to me, and I confirm that the inflation caused by the
jump table at patch 4 is now gone.

Acked-by: Willy Tarreau <w@....eu>

Willy