linux-kernel - Re: [PATCH] of: property: Create devlink between PCI Host bridge and Root Port suppliers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <re6ed3n5scouxoj66ysqitkm5zmloj5t5pwlvdkkvgcj4pshcs@d4ibi32x4qcs>
Date: Sun, 8 Feb 2026 17:09:48 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
Cc: Saravana Kannan <saravanak@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, robh@...nel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, qiang.yu@....qualcomm.com
Subject: Re: [PATCH] of: property: Create devlink between PCI Host bridge and
 Root Port suppliers

On Sun, Feb 08, 2026 at 08:51:33PM +0530, Manivannan Sadhasivam wrote:
> On Sat, Feb 07, 2026 at 05:27:21PM -0800, Saravana Kannan wrote:
> > On Thu, Feb 5, 2026 at 1:01 AM Manivannan Sadhasivam
> > <manivannan.sadhasivam@....qualcomm.com> wrote:
> > >
> > > On Thu, Feb 05, 2026 at 09:50:20AM +0100, Konrad Dybcio wrote:
> > > > On 2/5/26 8:06 AM, Manivannan Sadhasivam wrote:
[..]
> > 3. Just create device links if you know you have a weird case of
> > dependency that fw_devlink doesn't pick up? It's generally more
> > painful to get fw_devlink to ignore what it thinks is a dependency,
> > but thankfully that's not the case here.
> > 
> 
> I would love to solve it in the PCI layer itself if there is a way. But I don't
> know how. The PCI framework becomes operational only when the controller driver
> probes and registers with the framework. But we need to create devlink even
> before the controller driver probes.
> 

The devlinks are just an optimization, so worst case you should be able
to create the link on the first probe attempt to avoid further probe
deferrals until the dependencies are in place?

Just like we could have done for all those other provider types that
of_link_property() handles.

> We do have the PCI class which gets registered during postcore_initcall(), FYI.
> 
> > Please continue cc'ing me in future patches trying to address this.
> > I'm happy to give guidance if you get stuck.
> > 
> 
> Sure, thanks for the review. Even I'm not super happy with plumbing PCI
> specific code in the core DT layer, but I'm not sure of doing it elsewhere. Any
> suggestions from you would be greatly appreciated!
> 

I don't understand your concern, Saravana, of_link_property() is all
about tangling subsystem-specific details into the of-core.

Regards,
Bjorn

> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்