linux-kernel - Re: [PATCH v2] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYoNI7f0OMegFBM3@lizhi-Precision-Tower-5810>
Date: Mon, 9 Feb 2026 11:36:51 -0500
From: Frank Li <Frank.li@....com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: peng.fan@....com, andersson@...nel.org, festevam@...il.com,
	imx@...ts.linux.dev, kernel@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-remoteproc@...r.kernel.org, mathieu.poirier@...aro.org,
	s.hauer@...gutronix.de
Subject: Re: [PATCH v2] remoteproc: imx_rproc: Check return value of
 regmap_attach_dev() in imx_rproc_mmio_detect_mode()

On Mon, Feb 09, 2026 at 01:14:07PM +0800, Chen Ni wrote:
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Suggested-by: Peng Fan <peng.fan@....com>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
> Changes in v2:
> - Use dev_err() + return ret instead of dev_err_probe()

why?

Frank
> ---
>  drivers/remoteproc/imx_rproc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index f5f916d67905..75baf905988b 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
>  	}
>
>  	priv->regmap = regmap;
> -	regmap_attach_dev(dev, regmap, &config);
> +	ret = regmap_attach_dev(dev, regmap, &config);
> +	if (ret) {
> +		dev_err(dev, "regmap attach failed\n");
> +		return ret;
> +	}
>
>  	if (priv->gpr) {
>  		ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>