[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<AM7P189MB1009B650CBEF568DEB98B39BE365A@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
Date: Mon, 9 Feb 2026 08:20:24 +0100
From: Maud Spierings <maud_spierings@...mail.com>
To: jens.glathe@...schoolsolutions.biz, Bjorn Andersson
<andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: x1-vivobook-s15: add Hamoa- and
Purwa-compatible device trees
Hi Jens,
Thanks for doing this, definetly not up for it myself right now. I will
try to test everything somewhere this week.
One little comment:
On 2/8/26 22:25, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>
> The ASUS Vivobook S15 (S5507) [1] is available with Hamoa and Purwa SoC.
>
> Add the Purwa-based device tree, and change the Hamoa-based device tree to include
> x1-asus-vivobook-s15.dtsi.
>
> [1]: https://www.asus.com/de/laptops/for-home/vivobook/asus-vivobook-s-15-s5507/techspec/
>
> Signed-off-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 1425 +-------------------
> .../boot/dts/qcom/x1p42100-asus-vivobook-s15.dts | 47 +
> 3 files changed, 89 insertions(+), 1385 deletions(-)
>
[snip]
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> + * Copyright (c) 2024, Xilin Wu <wuxilin123@...il.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "hamoa.dtsi"
> +#include "x1-asus-vivobook-s15.dtsi"
> +
> +/ {
> + model = "ASUS Vivobook S 15";
> + compatible = "asus,vivobook-s15", "qcom,x1e80100";
> + chassis-type = "laptop";
> +};
> +
> +&gpu_zap_shader {
> + firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcdxkmsuc8380.mbn";
> +};
> +
> +&iris {
> + firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcvss8380.mbn";
> + status = "okay";
> +};
> +
> +&remoteproc_adsp {
> + firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qcadsp8380.mbn",
> + "qcom/x1e80100/ASUSTeK/vivobook-s15/adsp_dtbs.elf";
> +
> + status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> + firmware-name = "qcom/x1e80100/ASUSTeK/vivobook-s15/qccdsp8380.mbn",
> + "qcom/x1e80100/ASUSTeK/vivobook-s15/cdsp_dtbs.elf";
> +
> + status = "okay";
> +};
> +
> diff --git a/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s15.dts
> new file mode 100644
> index 0000000000000000000000000000000000000000..336bd0c10992f2a60b384b247ae2219f75d8b8a4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-vivobook-s15.dts
> @@ -0,0 +1,47 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> + * Copyright (c) 2024, Xilin Wu <wuxilin123@...il.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "purwa.dtsi"
> +#include "x1-asus-vivobook-s15.dtsi"
> +
> +/delete-node/ &pmc8380_6;
> +/delete-node/ &pmc8380_6_thermal;
> +
> +/ {
> + model = "ASUS Vivobook S 15 X1P-42-100";
> + compatible = "asus,vivobook-s15-x1p4", "qcom,x1p42100";
> + chassis-type = "laptop";
> +};
> +
> +&gpu {
> + status = "okay";
> +};
Isn't this status already set in x1-asus-vivobook-s15.dtsi?
It isn't in the x1e dts, so it would have to be there too if it isn't.
Besides that I'll leave it to the pros!
Kind regards,
Maud
> +
> +&gpu_zap_shader {
> + firmware-name = "qcom/x1p42100/ASUSTeK/vivobook-s15/qcdxkmsucpurwa.mbn";
> +};
> +
> +&iris {
> + firmware-name = "qcom/x1p42100/ASUSTeK/vivobook-s15/qcvss8380.mbn";
> + status = "okay";
> +};
> +
> +&remoteproc_adsp {
> + firmware-name = "qcom/x1p42100/ASUSTeK/vivobook-s15/qcadsp8380.mbn",
> + "qcom/x1p42100/ASUSTeK/vivobook-s15/adsp_dtbs.elf";
> +
> + status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> + firmware-name = "qcom/x1p42100/ASUSTeK/vivobook-s15/qccdsp8380.mbn",
> + "qcom/x1p42100/ASUSTeK/vivobook-s15/cdsp_dtbs.elf";
> +
> + status = "okay";
> +};
> +
>
Powered by blists - more mailing lists