linux-kernel - Re: [PATCH v2 10/11] mfd: motorola-cpcap: diverge configuration per-board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5AA39777-F5C8-4AD5-A5C2-47265C8213F5@gmail.com>
Date: Mon, 09 Feb 2026 10:42:02 +0200
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Lee Jones <lee@...nel.org>,
 Pavel Machek <pavel@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Dixit Parmar <dixitparmar19@...il.com>,
 Tony Lindgren <tony@...mide.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-input@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 10/11] mfd: motorola-cpcap: diverge configuration per-board



9 лютого 2026 р. 10:18:57 GMT+02:00, Andy Shevchenko <andriy.shevchenko@...el.com> пише:
>On Sun, Feb 08, 2026 at 05:19:49PM +0200, Svyatoslav Ryhel wrote:
>> 8 лютого 2026 р. 14:54:53 GMT+02:00, Andy Shevchenko <andriy.shevchenko@...el.com> пише:
>> >On Fri, Feb 06, 2026 at 07:28:44PM +0200, Svyatoslav Ryhel wrote:
>
>...
>
>> >> -static const struct of_device_id cpcap_of_match[] = {
>> >> -	{ .compatible = "motorola,cpcap", },
>> >> -	{ .compatible = "st,6556002", },
>> >> -	{},
>> >> -};
>> >> -MODULE_DEVICE_TABLE(of, cpcap_of_match);
>> >> -
>> >>  static const struct spi_device_id cpcap_spi_ids[] = {
>> >>  	{ .name = "cpcap", },
>> >>  	{ .name = "6556002", },
>> >> +	{ .name = "mapphone-cpcap", },
>> >>  	{},
>> >>  };
>> >
>> >This  also needs to be converted to use driver data.
>> 
>> I can do that, but is it needed?
>
>For the consistency's sake.
>Also brief look at MFD SPI drivers I see that most of them use driver data.
>All that is redundancy? Maybe clean them up as well to show the point?
>
>> This id table, if I understand correctly, is here solely to silence warnings
>> about missing spi id table. Driver itself does not use it in any way and will
>> never use since all available devices that use this driver rely solely on the
>> device tree, all possible future devices will be relying on device tree too
>> due to obvious reasons.
>
>Then maybe SPI should be fixed to avoid this table to be present? (But don't
>waste your time, it will be a rabbit hole.)
>
>> >>  MODULE_DEVICE_TABLE(spi, cpcap_spi_ids);
>
>...
>
>> And please, may you contain all your reviewing in one iteration. Then both of
>> us will spend less time working on the patch. Thank you!
>
>It's an impossible request, you should understand that. If you want, use AI
>or your robot colleagues for that, I'm just a human being, I can't see
>everything at once.
>

Ability to see only nits and don't see the possible issues seems to be a talent.

>