linux-kernel - Re: [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYmdn4sHxxD1KK0k@smile.fi.intel.com>
Date: Mon, 9 Feb 2026 10:41:03 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomas Melin <tomas.melin@...sala.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>,
	Nuno Sa <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>,
	Olivier Moysan <olivier.moysan@...s.st.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities

On Mon, Feb 09, 2026 at 09:24:09AM +0200, Tomas Melin wrote:
> On 05/02/2026 18:34, Andy Shevchenko wrote:
> > On Thu, Feb 05, 2026 at 12:24:11PM +0000, Tomas Melin wrote:

...

> >> +	if (iio_backend_has_caps(st->back, IIO_BACKEND_CAP_BUFFER)) {
> >> +		ret = devm_iio_backend_request_buffer(&spi->dev, st->back,
> >> +						      indio_dev);
> > 
> > With
> > 
> > 	struct device *dev = &spi->dev;
> > 
> > at the top, this one becomes exactly a 80 character line.
> > And in general it will help cleaning up the rest afterwards.
> 
> Given it seems it would still be 81 characters long I would like to
> leave this change as it also creates a bit of noise.

		ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);

We have different arithmetics for sure, I have it 80.

"There are *two* problems in programming: naming, cache invalidation,
 and off-by-one error."

> >> +		if (ret)
> >> +			return ret;
> >> +	}

-- 
With Best Regards,
Andy Shevchenko