linux-kernel - Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f1bc7e6-a981-4467-89ef-609080436286@kernel.org>
Date: Mon, 9 Feb 2026 11:01:45 +0100
From: "David Hildenbrand (Arm)" <david@...nel.org>
To: Marek Szyprowski <m.szyprowski@...sung.com>,
 Mark Brown <broonie@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 "Rob Herring (Arm)" <robh@...nel.org>,
 Oreoluwa Babatunde <oreoluwa.babatunde@....qualcomm.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()

On 2/9/26 10:59, Marek Szyprowski wrote:
> On 09.02.2026 09:11, David Hildenbrand (Arm) wrote:
>> On 1/28/26 17:28, Mark Brown wrote:
>>> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
>>> triggers build warnings:
>>>
>>> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
>>> /tmp/next/build/include/linux/cma.h:68:13: warning:
>>> 'cma_skip_dt_default_reserved_mem' defined but not used
>>> [-Wunused-function]
>>>      68 | static bool cma_skip_dt_default_reserved_mem(void)
>>>         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> which are fatal with -Werror.
>>>
>>> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework
>>> detect "cma=" kernel param")
>>> Signed-off-by: Mark Brown <broonie@...nel.org>
>>
>> $ git show 26332ae848f08
>> fatal: ambiguous argument '26332ae848f08': unknown revision or path
>> not in the working tree.
>>
>> This is not upstream or against an mm tree. Against which tree is it?
> 
> The fix for this issue has been squashed into commit 0fd17e598333 ("of:
> reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> and merged to v6.19-rc8, so the above fix is not longer needed.

Ah, that's just what I wanted to ask: can this be squashed :)

Thanks!

-- 
Cheers,

David