linux-kernel - Re: [PATCH] usbhid: tolerate intermittent errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ1CL5Ea7twCdqLb2YfpOCpwrydakMnhf=K-puc-SBQYOnn5g@mail.gmail.com>
Date: Mon, 9 Feb 2026 11:49:34 +0100
From: Liam Mitchell <mitchell.liam@...il.com>
To: Oliver Neukum <oneukum@...e.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, 
	Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbhid: tolerate intermittent errors

On Mon, 9 Feb 2026 at 11:06, Oliver Neukum <oneukum@...e.com> wrote:
> On 08.02.26 18:10, Liam Mitchell wrote:
> > Modifies the usbhid error handling logic to better handle intermittent
> > errors like EPROTO, which should only need resubmission of URBs and not
> > full device reset.
> >
> > Reduces initial retry delay from 13ms to 1ms. The faster the URB is
> > resubmitted, the lower the chance that user events will be missed.
>
> in this case I have to ask the obvious question: Why wait at all?
> It would seem to me that if you have spurious or intermittent errors
> the right time to retry is immediately.

Agreed.

This patch is intentionally small because I wasn't sure if a more
comprehensive fix is wanted.

Regards,
Liam