linux-kernel - Re: [PATCH] usbhid: tolerate intermittent errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1cbfe87-5097-4630-b848-4575ebcf3b09@rowland.harvard.edu>
Date: Mon, 9 Feb 2026 09:47:29 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Oliver Neukum <oneukum@...e.com>
Cc: Liam Mitchell <mitchell.liam@...il.com>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>, linux-usb@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbhid: tolerate intermittent errors

On Mon, Feb 09, 2026 at 11:06:03AM +0100, Oliver Neukum wrote:
> On 08.02.26 18:10, Liam Mitchell wrote:
> > Modifies the usbhid error handling logic to better handle intermittent
> > errors like EPROTO, which should only need resubmission of URBs and not
> > full device reset.
> > 
> > Reduces initial retry delay from 13ms to 1ms. The faster the URB is
> > resubmitted, the lower the chance that user events will be missed.
> 
> Hi,
> 
> in this case I have to ask the obvious question: Why wait at all?

Because of the possibility that the error was caused by transient 
interference that might not go away immediately.

> It would seem to me that if you have spurious or intermittent errors
> the right time to retry is immediately.

It depends on the cause of the errors.  In any case, a short delay, such 
as 1 ms, should not make much difference.

Alan Stern