linux-kernel - Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <049f04c549bbea2f22b4fdab485beaa86af1b7db.camel@microchip.com>
Date: Mon, 9 Feb 2026 14:46:55 +0000
From: <Victor.Duicu@...rochip.com>
To: <linux@...ck-us.net>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <corbet@....net>, <krzk@...nel.org>
CC: <Marius.Cristea@...rochip.com>, <linux-hwmon@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-doc@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X

Hi Krzysztof,

> > +
> > +  interrupts:
> > +    items:
> > +      - description: Signal coming from ALERT/THERM pin.
> > +      - description: Signal coming from THERM/ADDR pin.
> > +      - description: Signal coming from SYS_SHDN pin.
> 
> As Guenter pointed out - code is wrong (thanks Guenter!)
> 
> This does not match your if:then:.
> 
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: alert-therm
> > +      - const: therm-addr
> > +      - const: sys-shutdown
> 
> Neither this.
> 
> 
> ...
> 
> > +    then:
> > +      properties:
> > +        interrupts-names:
> > +          items:
> > +            - const: alert-therm
> > +            - const: sys-shutdown
> 
> So three interrupts, but two AND three interrupt-names? This is mess.

I was mistakenly under the impression that I could set two out of three
possible interrupts depending on the chip. But I understand now that
in the code written as is all chips have three interrupts.

Indeed, this error was present multiple versions in the past and you
identified it in v4 of the IIO driver. I failed to fix it then, I
apologize.

I will use two interrupts only and remove the if:then code regarding
them.

Kind Regards,
Victor