linux-kernel - [PATCH] drm/bridge: synopsys: dw-dp: correct signedness bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20260210173004.791856-1-ethantidmore06@gmail.com>
Date: Tue, 10 Feb 2026 11:30:04 -0600
From: Ethan Tidmore <ethantidmore06@...il.com>
To: andy.yan@...k-chips.com,
	andrzej.hajda@...el.com,
	neil.armstrong@...aro.org,
	rfoss@...nel.org
Cc: Laurent.pinchart@...asonboard.com,
	jonas@...boo.se,
	jernej.skrabec@...il.com,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Ethan Tidmore <ethantidmore06@...il.com>
Subject: [PATCH] drm/bridge: synopsys: dw-dp: correct signedness bug

The function dw_dp_video_need_vsc_sdp() returns a bool type but in a
error path -EINVAL is returned. This allows the possibility of this
function returning true when dw_dp_get_bridge_state() fails.

Signed-off-by: Ethan Tidmore <ethantidmore06@...il.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 432342452..a80d955f2 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
-- 
2.53.0