linux-kernel - Re: [PATCH v2] staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DGBI1D0LN96R.1B34WZQVUSUF8@gmail.com>
Date: Tue, 10 Feb 2026 12:38:51 -0600
From: "Ethan Tidmore" <ethantidmore06@...il.com>
To: "Haroen Tmimi" <tmimiharoen@...il.com>, <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove redundant 'Adapter'
 variable in HalPhyRf_8723B

On Tue Feb 10, 2026 at 11:14 AM CST, Haroen Tmimi wrote:
> The variable Adapter was declared and initialized locally in
> an if-statement, but it shadowed a variable of the same name and
> value declared in the function scope (line 169).
>
> Removing the inner declaration allows the code to use the existing
> outer variable, resolving a -Wshadow warning.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@...il.com>
> ---
> Changes in v2: 
> Removed the white space in line 211, which caused a coding style warning
> (reported by Greg K-H).
>  drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index f712d0345b99..0f915589b518 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B(
>  	}
>  
>  	if (Method == TXAGC) {
> -
>  		pDM_Odm->Remnant_OFDMSwingIdx[RFPath] = pDM_Odm->Absolute_OFDMSwingIdx[RFPath];
>  
>  		pDM_Odm->Modify_TxAGC_Flag_PathA = true;

I don't see the Adapter variable here? 

I believe you meant to use "git commit --amend" but, just made the v2
its own patch without the previous diff.

Thanks,

ET