linux-kernel - Re: [PATCH v9 00/21] wifi: nxpwifi: create nxpwifi to support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1d9bc37-6078-4240-8b06-cfdc435eadd0@kernel.org>
Date: Wed, 11 Feb 2026 10:42:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jeff Chen <jeff.chen_1@....com>, Johannes Berg <johannes@...solutions.net>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 briannorris@...omium.org, francesco@...cini.it, s.hauer@...gutronix.de
Subject: Re: [PATCH v9 00/21] wifi: nxpwifi: create nxpwifi to support

On 05/02/2026 07:48, Jeff Chen wrote:
> On Wed, Feb 04, 2026 at 09:09:25 PM +0100, Johannes Berg wrote:
>>>
>>>     Devicetree bindings note
>>>     ------------------------
>>>
>>>     The previous version included a devicetree binding document for
>>>     `nxp,iw61x.yaml`. Since Device Tree support for this device is optional
>>>     and not required for current SDIO-based bring-up, the binding has been
>>>     dropped from this series. A proper schema will be submitted separately
>>>     once DT usage becomes relevant, so that binding review can be handled
>>>     in the correct subsystem and without blocking this driver introduction.
>>
>> You should probably have dropped _all_ the DT/OF *code* as well,
>> otherwise what's the point of dropping the binding review when you still
>> bake the binding into the code, no?
>>
>> johannes
>>
> 
> Hi Johannes,
> 
> Thanks for the question. To clarify what changed in v9:
> 
> I dropped only the DT binding YAML from this wireless-only series because
> bindings are reviewed by the Devicetree subsystem. The driver keeps minimal

Huh, what? No, since when? Read docs in the kernel, it's complete
misinterpretation of kernel development model.

Reach to other people in NXP to guide you through basic submission
guidelines, so you won't be upstreaming 10 year old poor code (like last
version) or doing such trivial mistakes. They would tell you what you
have to do.


> and optional OF handling, but SDIO bring-up does not depend on any DT
> properties — enumeration is via SDIO VID/PID and the driver works without a

That's not true. Look at your code - you have OF calls.


> binding.
> 
> The plan is to submit the binding YAML (and any DT properties we actually need,
> e.g. OOB wake IRQ/regulators) as a separate patchset to the DT maintainers so

This is not how it works. We won't be reviewing DT submission separate
from wireless subsystem / maintainers.


Best regards,
Krzysztof