linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b95d7a49-6191-4d85-b725-4a941505b40d@gmail.com>
Date: Wed, 11 Feb 2026 12:07:45 +0200
From: Erikas Bitovtas <xerikasxx@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Peter Meerwald <pmeerw@...erw.net>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella
 CM36686 and CM36672P



On 2/11/26 8:49 AM, Krzysztof Kozlowski wrote:
> 
> There was CM36686 v1 and v2, so I do not understand versioning here.
> Also, lack of any changelog.
> 
> And how is it supposed to work for us? Try yourself:
> 
>   $ b4 diff 20260210-cm36686-v1-1-aef68dd46ad4@...il.com
>   Could not find lower series to compare against.
> 
> Please implement previous feedback.
> 
> Best regards,
> Krzysztof
> 

Since I am making changes to the existing driver instead of creating a new one,
I introduced a new patch series. As I mentioned in the cover letter, cm36686 is
fully compatible with vcnl4040, so instead of creating a new binding, I create a
fallback compatible for the device. I probably should have named this patch
series something else.
As for the previous feedback, I added the subject prefix and removed the
redundant phrasing.