linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f97c68d-0236-4d04-8199-768ecee7c4dd@kernel.org>
Date: Wed, 11 Feb 2026 11:10:56 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Erikas Bitovtas <xerikasxx@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Peter Meerwald <pmeerw@...erw.net>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella
 CM36686 and CM36672P

On 11/02/2026 11:07, Erikas Bitovtas wrote:
> 
> 
> On 2/11/26 8:49 AM, Krzysztof Kozlowski wrote:
>>
>> There was CM36686 v1 and v2, so I do not understand versioning here.
>> Also, lack of any changelog.
>>
>> And how is it supposed to work for us? Try yourself:
>>
>>   $ b4 diff 20260210-cm36686-v1-1-aef68dd46ad4@...il.com
>>   Could not find lower series to compare against.

Look here.

>>
>> Please implement previous feedback.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Since I am making changes to the existing driver instead of creating a new one,
> I introduced a new patch series. As I mentioned in the cover letter, cm36686 is
> fully compatible with vcnl4040, so instead of creating a new binding, I create a
> fallback compatible for the device. I probably should have named this patch
> series something else.

That's fine, but that's v3 of previous patches. Your work was to add
CM36686 support. How you do it, evolves, but patchset/work is one
continuous work. When you rework approach next time, you also start from
v1? And then you go back to previous solution of new driver it will jump
from v1 to v3?

> As for the previous feedback, I added the subject prefix and removed the
> redundant phrasing.

And how do I know it if there is no changelog with list of changes? Look
how many patches is here:
https://lore.kernel.org/linux-devicetree/

Best regards,
Krzysztof