linux-kernel - Re: [PATCH net v2] iavf: fix deadlock in reset handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d97612d0-09ed-4895-a22a-6fa73abfbbf5@redhat.com>
Date: Wed, 11 Feb 2026 12:50:57 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Petr Oros <poros@...hat.com>, netdev@...r.kernel.org
Cc: ivecera@...hat.com, aleksandr.loktionov@...el.com, shaojijie@...wei.com,
 Jacob Keller <jacob.e.keller@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] iavf: fix deadlock in reset handling

On 2/7/26 11:22 AM, Petr Oros wrote:
> -/**
> - * iavf_wait_for_reset - Wait for reset to finish.
> - * @adapter: board private structure
> - *
> - * Returns 0 if reset finished successfully, negative on timeout or interrupt.
> - */
> -int iavf_wait_for_reset(struct iavf_adapter *adapter)
> -{
> -	int ret = wait_event_interruptible_timeout(adapter->reset_waitqueue,
> -					!iavf_is_reset_in_progress(adapter),
> -					msecs_to_jiffies(5000));

AFAICS, after this change nobody waits anymore on reset_waitqueue, do we
still need such wait queue head? I think a bunch of additional code
could be dropped.

Thanks,

Paolo