netdev - Re: [PATCH] r8169: Fix iteration variable sign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <456EBE87.1070806@pobox.com>
Date:	Thu, 30 Nov 2006 06:20:39 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	torvalds@...l.org, Michael Buesch <mb@...sch.de>,
	netdev@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] r8169: Fix iteration variable sign

Francois Romieu wrote:
> This changes the type of variable "i" in rtl8169_init_one()
> from "unsigned int" to "int". "i" is checked for < 0 later,
> which can never happen for "unsigned". This results in broken
> error handling.
>     
> Signed-off-by: Michael Buesch <mb@...sch.de>
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>

ACK but doesn't seem to apply to 2.6.19?

should this go into #upstream rather than #upstream-fixes?


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html