netdev - Re: [PATCH] r8169: Fix iteration variable sign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611301514.14400.mb@bu3sch.de>
Date:	Thu, 30 Nov 2006 15:14:14 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Francois Romieu <romieu@...zoreil.com>, torvalds@...l.org,
	netdev@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] r8169: Fix iteration variable sign

On Thursday 30 November 2006 12:20, Jeff Garzik wrote:
> Francois Romieu wrote:
> > This changes the type of variable "i" in rtl8169_init_one()
> > from "unsigned int" to "int". "i" is checked for < 0 later,
> > which can never happen for "unsigned". This results in broken
> > error handling.
> >     
> > Signed-off-by: Michael Buesch <mb@...sch.de>
> > Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> 
> ACK but doesn't seem to apply to 2.6.19?
> 
> should this go into #upstream rather than #upstream-fixes?

Hm, I did this against latest linus' tree.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html