[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20061130.195208.71554173.davem@davemloft.net>
Date: Thu, 30 Nov 2006 19:52:08 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: tgraf@...g.ch
Cc: kaber@...sh.net, bunk@...sta.de, netdev@...r.kernel.org,
hadi@...erus.ca
Subject: Re: RFC: remove NET_CLS_POLICE?
From: Thomas Graf <tgraf@...g.ch>
Date: Mon, 27 Nov 2006 09:56:14 +0100
> * Patrick McHardy <kaber@...sh.net> 2006-11-26 14:21
> > One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify
> > handling, reshape_fail seems to be completely unhandled without
> > NET_CLS_POLICE and reclassification looks like it behaves
> > differently with tc actions. I'm not really sure what the
> > reshape_fail stuff is used for, but it looks like we would loose
> > a feature. Jamal?
>
> Yes, this is the reason why it wasn't removed yet. It always
> occured to me as a mystery why NET_ACT_POLICE didn't depend
> on the same logic inside the qdiscs. That needs to be resolved
> first. Also the compat code for the action variant to handle
> old policer configurations is horrible and should be done in
> a clear way.
Ok, I'll consider this the definitive statement of the
situation.
Adrian, it's not ready to be deleted yet.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists