netdev - Re: [NET_SCHED]: policer: restore compatibility with old iproute binaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20061130.195429.85820511.davem@davemloft.net>
Date:	Thu, 30 Nov 2006 19:54:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hadi@...erus.ca
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [NET_SCHED]: policer: restore compatibility with old iproute
 binaries

From: jamal <hadi@...erus.ca>
Date: Thu, 30 Nov 2006 06:43:36 -0500

> On 11/26/06, Patrick McHardy <kaber@...sh.net> wrote:
> >
> >
> >
> > [NET_SCHED]: policer: restore compatibility with old iproute binaries
> >
> > The tc actions increased the size of struct tc_police, which broke
> > compatibility with old iproute binaries since both the act_police
> > and the old NET_CLS_POLICE code check for an exact size match.
> >
> > Since the new members are not even used, the simple fix is to also
> > accept the size of the old structure. Dumping is not affected since
> > old userspace will receive a bigger structure, which is handled fine.
> >
> > Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> 
> Sorry, couldnt respond sooner. Was travelling and overloaded.
> Looks good although i havent run any of my tests. I will at some point.
> 
> Acked-by: Jamal Hadi  Salim

Applied to net-2.6.20, and I'll push this to -stable too.

Thanks everyone.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html