[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20061201.151737.124084161.davem@davemloft.net>
Date: Fri, 01 Dec 2006 15:17:37 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: hch@...radead.org
Cc: greearb@...delatech.com, Robert.Olsson@...a.slu.se,
adobriyan@...il.com, pavol.gono@...il.com, netdev@...r.kernel.org
Subject: Re: pktgen
From: Christoph Hellwig <hch@...radead.org>
Date: Fri, 1 Dec 2006 08:22:25 +0000
> On Thu, Nov 30, 2006 at 08:14:23PM -0800, David Miller wrote:
> > Agreed.
> >
> > Robert, please fix this by using a completion so that we can
> > wait for the threads to start up, something like this:
>
> No, that's wrong aswell :) Please use the kthread_ API that takes
> care of all this. kernel_thread is going away mid-term, so you'd
> have to do this work anyway.
I was going to suggest this Christophe, but I wanted a change small
and easy enough to verify in order to merge the fix into the -stable
branch. Converting the thing over to kthread would make the change
more risky in such a context.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists