netdev - Re: [RFC][GENETLINK] move command capabilities to flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165237269.3664.15.camel@localhost>
Date:	Mon, 04 Dec 2006 08:01:09 -0500
From:	jamal <hadi@...erus.ca>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [RFC][GENETLINK] move command capabilities  to flags

On Mon, 2006-04-12 at 10:20 +0100, Thomas Graf wrote:
> * jamal <hadi@...erus.ca> 2006-12-02 06:56
> > 
> > Dave,
> > If there is no objections on this approach, please apply this patch.
> > Against net-2.6.20
> > 
> > cheers,
> > jamal
> 
> > This patch moves command capabilities to command flags. Other than
> > being cleaner, saves several bytes.
> 
> Is it worth to save these 12 bytes by breaking compatibility? 

The savings bytes is one aspect; the other is the cleanliness.
transfering a boolean in that many bits is a little of overkill.
I think it is better to fix it now than later.
I know you mentioned libnl uses it. But that is something you can change
on your side. I dont know of any other app that uses it. 

> If you
> really want to do it, remove the obsoleted attribute types, I don't
> like dead bodies laying around :-)

I could resend the patch getting rid of those definitions. 

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html