netdev - Re: [RFC patch] driver for the Opencores Ethernet Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061205000709.GA23299@xi.wantstofly.org>
Date:	Tue, 5 Dec 2006 01:07:09 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Dan Nicolaescu <dann@....uci.edu>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC patch] driver for the Opencores Ethernet Controller

On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote:

> > > The Opencores Ethernet Controller is Verilog code that can be used to
> > > implement an Ethernet device in hardware. It needs to be coupled with
> > > a PHY and some buffer memory. Because of that devices that implement
> > > this controller can be very different. The code here tries to support
> > > that by having some parameters that need to be defined at compile
> > > time.
> > 
> > Considering this, why don't you make it a platform driver?
> 
> I didn't know about "platform drivers" before your mail. I guess I
> could convert it to that if that is the right thing to do. 

I definitely think so.  Check the ep93xx_eth driver for an example.

> (It might be an overkill given that the device is kind of simple and
> embedded people prefer small code...)

..until someone decides that he wants to build a design with two of
these ethernet cores instead of just one, at which point the entire
"Let's use #defines for everything" plan breaks down badly.

> Any comments on the driver itself? 

Sorry, no, I didn't look at it.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html