netdev - Re: [PATCH 4/4][SCTP]: Change adaption -> adaptation as per the latest API draft.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061214.145929.116355686.davem@davemloft.net>
Date:	Thu, 14 Dec 2006 14:59:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sri@...ibm.com
Cc:	netdev@...r.kernel.org, lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH 4/4][SCTP]: Change adaption -> adaptation as per the
 latest API draft.

From: Sridhar Samudrala <sri@...ibm.com>
Date: Thu, 14 Dec 2006 14:22:16 -0800

> On Wed, 2006-12-13 at 18:03 -0800, David Miller wrote:
> > From: Sridhar Samudrala <sri@...ibm.com>
> > Date: Wed, 13 Dec 2006 17:38:52 -0800
> > 
> > > These parameters are not used by user-space apps. They define the
> > > parameters used by the protocol in SCTP headers that go on wire.
> > 
> > There is no __KERNEL__ ifdef protection for these defines,
> > and the linux/sctp.h header is exported to userspace via
> > include/linux/Kbuild, therefore the interface is exposed to
> > userspace and you cannot break it.
> 
> I didn't know that all the files under include/linux are exported
> to userspace.

Not all of them, only select ones specified in the Kbuild file.

If these structures and defines are meant for kernel-only, or only
partially so, you should either annotate linux/sctp.h with
appropriate __KERNEL__ ifdefs, or remove the header file from
include/linux/Kbuild

You cannot remove the file from Kbuild if it somehow is required
by your SCTP user.h header file, for example.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html