netdev - Re: [PATCH 1/4] net: make dev_kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061214.150031.68042040.davem@davemloft.net>
Date:	Thu, 14 Dec 2006 15:00:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hch@...radead.org
Cc:	shemminger@...l.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] net: make dev_kfree_skb_irq not inline

From: Christoph Hellwig <hch@...radead.org>
Date: Thu, 14 Dec 2006 22:30:09 +0000

> Maybe you should only move the slowpath out of line ala:
> 
> static inline void dev_kfree_skb_irq(struct sk_buff *skb)
> {
> 	if (atomic_dec_and_test(&skb->users)) 
> 		__dev_kfree_skb_irq(skb);
> }

The atomic operation all by itself is either a function
call or a 6-7 instruction sequence, so the inlining doesn't
make sense even in this case.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html