netdev - Re: [patch 05/14] e1000: Fix Wake-on-Lan with forced gigabit speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4582B21C.2060006@garzik.org>
Date:	Fri, 15 Dec 2006 09:33:00 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Arjan van de Ven <arjan@...ux.intel.com>
CC:	netdev@...r.kernel.org
Subject: Re: [patch 05/14] e1000: Fix Wake-on-Lan with forced gigabit speed

Arjan van de Ven wrote:
> Subject: e1000: Fix Wake-on-Lan with forced gigabit speed
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> If the user has forced gigabit speed, phy power management must be disabled;
> otherwise the NIC would try to negotiate to a linkspeed of 10/100 mbit on
> shutdown, which would lead to a total loss of link. This loss of link breaks
> Wake-on-Lan and IPMI.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
> ---
> 
>  drivers/net/e1000/e1000_main.c |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> Index: linux-2.6/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/e1000/e1000_main.c
> +++ linux-2.6/drivers/net/e1000/e1000_main.c
> @@ -732,6 +732,20 @@ e1000_reset(struct e1000_adapter *adapte
>  	if (e1000_init_hw(&adapter->hw))
>  		DPRINTK(PROBE, ERR, "Hardware Error\n");
>  	e1000_update_mng_vlan(adapter);
> +
> +	/* if (adapter->hwflags & HWFLAGS_PHY_PWR_BIT) { */
> +	if (adapter->hw.mac_type >= e1000_82544 &&
> +	    adapter->hw.mac_type <= e1000_82547_rev_2 &&
> +	    adapter->hw.autoneg == 1 &&
> +	    adapter->hw.autoneg_advertised == ADVERTISE_1000_FULL) {
> +		uint32_t ctrl = E1000_READ_REG(&adapter->hw, CTRL);
> +		/* clear phy power management bit if we are in gig only mode,
> +		 * which if enabled will attempt negotiation to 100Mb, which
> +		 * can cause a loss of link at power off or driver unload */
> +		ctrl &= ~E1000_CTRL_SWDPIN3;
> +		E1000_WRITE_REG(&adapter->hw, CTRL, ctrl);

NAK, for same reason as other patches.

I have been telling Intel this for months, yet keep seeing the same patches.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html