lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Dec 2006 09:33:15 -0500 From: Jeff Garzik <jeff@...zik.org> To: Arjan van de Ven <arjan@...ux.intel.com> CC: netdev@...r.kernel.org Subject: Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging Arjan van de Ven wrote: > Subject: e1000: disable TSO on the 82544 with slab debugging > From: Jesse Brandeburg <jesse.brandeburg@...el.com> > > CONFIG_DEBUG_SLAB changes alignments of the data structures the slab > allocators return. These break certain workarounds for TSO on the 82544. > Since DEBUG_SLAB is relatively rare and not used for performance sensitive > cases, the simplest fix is to disable TSO in this special situation. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> > Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com> > Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com> > --- > > drivers/net/e1000/e1000_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: linux-2.6/drivers/net/e1000/e1000_main.c > =================================================================== > --- linux-2.6.orig/drivers/net/e1000/e1000_main.c > +++ linux-2.6/drivers/net/e1000/e1000_main.c > @@ -911,6 +911,12 @@ e1000_probe(struct pci_dev *pdev, > (adapter->hw.mac_type != e1000_82547)) > netdev->features |= NETIF_F_TSO; > > +#ifdef CONFIG_DEBUG_SLAB > + /* 82544's work arounds do not play nicely with DEBUG SLAB */ > + if (adapter->hw.mac_type == e1000_82544) > + netdev->features &= ~NETIF_F_TSO; > +#endif NAK, same reason as the others - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists