lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 16 Dec 2006 16:11:41 +0100
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Rainer Baumann <baumann@....ee.ethz.ch>
Cc:	Stephen Hemminger <shemminger@...l.org>, netdev@...R.KERNEL.ORG,
	netem@...l.org
Subject: Re: [PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

* Rainer Baumann | 2006-12-15 11:39:28 [+0100]:

>Patch for linux kernel 2.6.18.13:
>http://tcn.hypert.net/tcn_kernel_configfs.patch

This patch isn't ok ( maybe this patch benefit from gcc padding behaviours):

static struct pktdelay get_next_delay(struct netem_sched_data *q)
{
  struct pktdelay retval;

  [...]

  return retval;
}

There are also some tiny coding style issues.


Hagen

PS: please setup you mua to break lines - it's a little bit difficult to read
you mails
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists