netdev - Re: [S2IO] De-typedef driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45842152.10408@garzik.org>
Date:	Sat, 16 Dec 2006 11:39:46 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Ramkrishna Vepa <Ramkrishna.Vepa@...erion.com>
CC:	Ralf Baechle <ralf@...ux-mips.org>, netdev@...r.kernel.org
Subject: Re: [S2IO] De-typedef driver

Ramkrishna Vepa wrote:
>> I stomped over the s2io driver when doing an allyesconfig build for
> IP27
>> where there was a namespace collision between the IP27 code and the
> s2io
>> driver which both use a nic_t.  I decieded both were broken, IP27
> should
>> not export the type and s2io was a totally typedef polluted piece of
> code.
>> So here's the s2io part of the fix.
> [Ram] Agreed this is a problem. Please leave the typedef but change
> nic_t to xframe_t. This will make it unique and is a much simpler
> change.

More simple yes, but not any closer to the Linux kernel (and POSIX) 
preferred style.

Most kernel devs' brains work better after applying Ralf's patch...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html