netdev - Re: [Bugme-new] [Bug 7708] New: unregister_netdev() should return unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061218.173745.08333482.davem@davemloft.net>
Date:	Mon, 18 Dec 2006 17:37:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...l.org
Cc:	akpm@...l.org, benjamin.li@...gic.com,
	bugme-daemon@...zilla.kernel.org, netdev@...r.kernel.org
Subject: Re: [Bugme-new] [Bug 7708] New: unregister_netdev() should return
 unregister_netdevice() return code

From: Stephen Hemminger <shemminger@...l.org>
Date: Mon, 18 Dec 2006 15:50:57 -0800

> On Mon, 18 Dec 2006 15:21:11 -0800
> Andrew Morton <akpm@...l.org> wrote:
> 
> > > net/core/dev.c:unregister_netdev() function is a wrapper around
> > > net/core/dev.c:unregister_netdevice().  The unregister_netdevice() function
> > > returns a return code while unregister_netdev() currently does not.  For
> > > completeness, we should pass the return code from unregister_netdevice() all the
> > > way to the caller.  unregister_netdev() should not swallow the return code.
> > > 
> > 
> > Certainly there's some truth in that ;)
> > 
> > Is there some reason why you want to test the unregister_netdev() return
> > value?
> The only return value is -ENODEV, so I would vote for both just being void

Me too.

FWIW, I think bug reports like this are a lot of back-and-forth waste
of time.  If it's important enough to someone, let them write a
god-damn patch for something so amazingly trivial.  With the bugzill
entry, you have to respond to it, change it's diapers, etc.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html