netdev - Re:[PATCH]Fix BUG of ip_rt_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Dec 2006 09:45:25 +0800
From:	Li Yewang <lyw@...jing-fnst.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org
Subject: Re:[PATCH]Fix BUG of ip_rt_send_redirect()

David Miller <davem@...emloft.net> wrote:

> Applied, but I had to fix many errors in your patch by hand.
> Please take care of these details next time.
> 
> Here, your email client wrapped the lines in the patch, corrupting it.
> 
> Please use real tab characters, when necessary, in the indentation of
> new code lines that you add, not just spaces.
> 
> Thank you.

Mr David Miller

I have made another patch file about the ip_rt_send_redirect().
This patch has not wrapped lines, and can be patched into the kernel.

Following is my patch:

signed-off-by: Li Yewang <lyw@...jing-fnst.com>

--- a/net/ipv4/route.org.c	2006-12-19 09:22:16.260271000 +0800
+++ a/net/ipv4/route.c	2006-12-19 09:22:16.241273888 +0800
@@ -1327,7 +1327,8 @@ void ip_rt_send_redirect(struct sk_buff 
 	/* Check for load limit; set rate_last to the latest sent
 	 * redirect.
 	 */
-	if (time_after(jiffies,
+	if (rt->u.dst.rate_tokens == 0 ||
+	    time_after(jiffies,
 		       (rt->u.dst.rate_last +
 			(ip_rt_redirect_load << rt->u.dst.rate_tokens)))) {
 		icmp_send(skb, ICMP_REDIRECT, ICMP_REDIR_HOST, rt->rt_gateway);


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html