netdev - Re: [patch] ifb double-counts packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0612231355290.29784@twinlark.arctic.org>
Date:	Sat, 23 Dec 2006 13:58:24 -0800 (PST)
From:	dean gaudet <dean@...tic.org>
To:	jamal <hadi@...erus.ca>
cc:	netdev@...r.kernel.org
Subject: Re: [patch] ifb double-counts packets

On Sat, 23 Dec 2006, jamal wrote:

> On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote:
> > it seems that ifb counts packets twice... both at xmit time and also in 
> > the tasklet.  i'm not sure which one of the two to drop, but here's a 
> > patch for dropping the counting at xmit time.
> 
> Good catch but not quite right. The correct way to do it is to increment
> the rx_ counters instead of tx_ right at the top of  ifb_xmit().
> 
> Do you wanna resubmit your patch with these chmages and hopefully tested
> for your situation?

heh yeah that makes more sense :)

-dean

Signed-off-by: dean gaudet <dean@...tic.org>

Index: linux/drivers/net/ifb.c
===================================================================
--- linux.orig/drivers/net/ifb.c	2006-11-29 13:57:37.000000000 -0800
+++ linux/drivers/net/ifb.c	2006-12-23 13:52:39.000000000 -0800
@@ -154,8 +154,8 @@
 	int ret = 0;
 	u32 from = G_TC_FROM(skb->tc_verd);
 
-	stats->tx_packets++;
-	stats->tx_bytes+=skb->len;
+	stats->rx_packets++;
+	stats->rx_bytes+=skb->len;
 
 	if (!from || !skb->input_dev) {
 dropped:
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html