netdev - Re: [patch] ifb double-counts packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1166880592.3763.3.camel@localhost>
Date:	Sat, 23 Dec 2006 08:29:52 -0500
From:	jamal <hadi@...erus.ca>
To:	dean gaudet <dean@...tic.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [patch] ifb double-counts packets

On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote:
> it seems that ifb counts packets twice... both at xmit time and also in 
> the tasklet.  i'm not sure which one of the two to drop, but here's a 
> patch for dropping the counting at xmit time.

Good catch but not quite right. The correct way to do it is to increment
the rx_ counters instead of tx_ right at the top of  ifb_xmit().

Do you wanna resubmit your patch with these chmages and hopefully tested
for your situation?

cheers,
jamal


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html