lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0612230232410.29784@twinlark.arctic.org>
Date:	Sat, 23 Dec 2006 02:35:50 -0800 (PST)
From:	dean gaudet <dean@...tic.org>
To:	Jamal Hadi Salim <hadi@...x.com>
cc:	netdev@...r.kernel.org
Subject: [patch] ifb double-counts packets

it seems that ifb counts packets twice... both at xmit time and also in 
the tasklet.  i'm not sure which one of the two to drop, but here's a 
patch for dropping the counting at xmit time.

patch against 2.6.20-rc1.

-dean

Signed-off-by: dean gaudet <dean@...tic.org>

Index: linux/drivers/net/ifb.c
===================================================================
--- linux.orig/drivers/net/ifb.c	2006-11-29 13:57:37.000000000 -0800
+++ linux/drivers/net/ifb.c	2006-12-23 02:14:31.000000000 -0800
@@ -154,9 +154,6 @@
 	int ret = 0;
 	u32 from = G_TC_FROM(skb->tc_verd);
 
-	stats->tx_packets++;
-	stats->tx_bytes+=skb->len;
-
 	if (!from || !skb->input_dev) {
 dropped:
 		dev_kfree_skb(skb);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ