netdev - Re: [PATCH] d80211: don't symlink empty default keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070110211157.5804f673@griffin.suse.cz>
Date:	Wed, 10 Jan 2007 21:11:57 +0100
From:	Jiri Benc <jbenc@...e.cz>
To:	Jan Kiszka <jan.kiszka@....de>
Cc:	netdev@...r.kernel.org, Ivo Van Doorn <ivdoorn@...il.com>
Subject: Re: [PATCH] d80211: don't symlink empty default keys

On Wed, 10 Jan 2007 21:05:28 +0100, Jan Kiszka wrote:
> Hmm, is this required? Will sysfs_remove_link panic on non-existent
> nodes?

No, it won't.

> If yes or if it's considered better style,

I consider it a better style as it's more tolerant to possible changes
in sysfs_remove_link.

> are you OK with
> catching NULL in ieee80211_key_sysfs_remove_default and refactoring the
> existing tests along this way?

Yes.

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html