netdev - [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ABAE69.4070105@redhat.com>
Date:	Mon, 15 Jan 2007 11:40:09 -0500
From:	Chris Lalancette <clalance@...hat.com>
To:	jgarzik@...ox.com, romieu@...zoreil.com
CC:	netdev@...r.kernel.org
Subject: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

(trying again, this time to the correct maintainer)

All,
     Similar to this commit:

http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d15e9c4d9a75702b30e00cdf95c71c88e3f3f51e

It's not safe in cp_start_xmit to blindly call spin_lock_irq and then spin_unlock_irq, since it may very well be the case that cp_start_xmit was called with interrupts already disabled (I came across this bug in the context of netdump in RedHat kernels, but the same issue holds, for example, in netconsole).  Therefore, replace all instances of spin_lock_irq and spin_unlock_irq with spin_lock_irqsave and spin_unlock_irqrestore, respectively, in cp_start_xmit().  I tested this against a fully-virtualized Xen guest, which happens to use the 8139cp driver to talk to the emulated hardware.  I don't have a real piece of 8139cp hardware to test on, so someone else will have to do that.

Signed-off-by: Chris Lalancette <clalance@...hat.com>

View attachment "linux-2.6.20-rc3-8139cp-xmit-irq-save.patch" of type "text/x-patch" (1106 bytes)