netdev - Re: [PATCH 1/2] [IrDA] irda-usb TX path optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070115.193754.59662700.davem@davemloft.net>
Date:	Mon, 15 Jan 2007 19:37:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	samuel@...tiz.org
Cc:	avl@...ic.at, netdev@...r.kernel.org,
	irda-users@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] [IrDA] irda-usb TX path optimization

From: Samuel Ortiz <samuel@...tiz.org>
Date: Mon, 15 Jan 2007 11:15:11 +0200

> Since we stop using dev_alloc_skb on the IrDA TX frame, we constantly run
> into the case of the skb headroom being 0, and thus we call skb_cow for
> every IrDA TX frame.
> This patch uses a local buffer and memcpy the skb to it, saving us a
> kmalloc for each of those IrDA TX frames.
> 
> Signed-off-by: Samuel Ortiz <samuel@...tiz.org>

Applied, thanks.

Technically this is a bug fix too because once an SKB hits the
transmit function it should essentially be immutable, ie. you
shouldn't be writing to it.  tcpdump sniffers could be looking
at the SKB, as one example.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html