netdev - Re: [PATCH 1/2] [IrDA] irda-usb TX path optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1H6fIz-0003Ne-00@gondolin.me.apana.org.au>
Date:	Tue, 16 Jan 2007 14:48:13 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	davem@...emloft.net (David Miller)
Cc:	samuel@...tiz.org, avl@...ic.at, netdev@...r.kernel.org,
	irda-users@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] [IrDA] irda-usb TX path optimization

David Miller <davem@...emloft.net> wrote:
> 
> Technically this is a bug fix too because once an SKB hits the
> transmit function it should essentially be immutable, ie. you
> shouldn't be writing to it.  tcpdump sniffers could be looking
> at the SKB, as one example.

We do have a way around that with skb_header_cloned.  In fact
it looks like VLAN should use it as otherwise TCP packets will
get copied unnecessarily.

This is still not optimal for AF_PACKET users since they will
still cause things like VLANs to do the copy even when it isn't
necessary because it doesn't touch any part of the packet that
AF_PACKET actually looks at.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html