netdev - Re: [IPROUTE 01/05]: Use tc_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ACA6B6.1090902@trash.net>
Date:	Tue, 16 Jan 2007 11:19:34 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...pl>
CC:	netdev@...r.kernel.org, shemminger@...l.org
Subject: Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

Jarek Poplawski wrote:
> On 10-01-2007 11:01, Patrick McHardy wrote:
> 
>>[IPROUTE]: Use tc_calc_xmittime where appropriate
>>
>>diff --git a/tc/tc_red.c b/tc/tc_red.c
>>index 385e7af..8f9bde0 100644
>>--- a/tc/tc_red.c
>>+++ b/tc/tc_red.c
>>@@ -71,7 +71,7 @@ int tc_red_eval_ewma(unsigned qmin, unsi
>> 
>> int tc_red_eval_idle_damping(int Wlog, unsigned avpkt, unsigned bps, __u8 *sbuf)
>> {
>>-	double xmit_time = tc_core_usec2tick(1000000*(double)avpkt/bps);
>>+	double xmit_time = tc_calc_xmittime(bps, avpkt);
> 
> 
> Return value changed to unsigned here.
> (According to iproute2-2.6.19-061214.) 


Right, this changes it from long (tc_core_usec2tick) to unsigned
int. It doesn't make any difference though, with 32 bit we can
represent transmission times up to ~1 hour (for a single packet),
which is far more than needed.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html