netdev - RE: [PATCH 2.6.20 1/5] s2io: updates for s2io driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 19 Jan 2007 02:55:27 -0500
From:	"Sivakumar Subramani" <Sivakumar.Subramani@...erion.com>
To:	"Jeff Garzik" <jeff@...zik.org>,
	"Ananda Raju" <Ananda.Raju@...erion.com>
Cc:	<netdev@...r.kernel.org>,
	"Leonid Grossman" <Leonid.Grossman@...erion.com>,
	"Alicia Pena" <Alicia.Pena@...erion.com>,
	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>,
	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>,
	"Sriram Rapuru" <Sriram.Rapuru@...erion.com>
Subject: RE: [PATCH 2.6.20 1/5] s2io: updates for s2io driver.

Hi Jeff,

Thanks for the comments and references.

As per you suggestion, we have resubmitted the patches with required
change.

Thanks,
~Siva 

-----Original Message-----
From: Jeff Garzik [mailto:jeff@...zik.org] 
Sent: Thursday, January 18, 2007 10:32 PM
To: Ananda Raju
Cc: netdev@...r.kernel.org; Leonid Grossman; Sivakumar Subramani; Alicia
Pena; sreenivasa.honnur@...rion.com; Ramkrishna Vepa
Subject: Re: [PATCH 2.6.20 1/5] s2io: updates for s2io driver.

Ananda Raju wrote:
> Hello,
> 
> List of changes in this patch:
> 
> 	This patch adds two load parameters napi and ufo. Previously
NAPI was 
> compilation option with these changes wan enable disable NAPI using 
> load parameter. Also we are introducing ufo load parameter to 
> enable/disable ufo feature
> 
> Signed-off-by: Sivakumar Subramani <sivakumar.subramani@...erion.com>

OK, you're getting closer :)

Problems that need correcting:

1) Your email subject line is a one-line summary of the patch.  "s2io: 
updates for s2io driver" is useless, because it tells us nothing about
the patch itself.  When applied in a series,

	git log master..upstream-fixes | git shortlog

will produce

	Ananda Raju (5):
	s2io: updates for s2io driver
	s2io: updates for s2io driver
	s2io: updates for s2io driver
	s2io: updates for s2io driver
	s2io: updates for s2io driver

which clearly makes it impossible to distinguish between changesets. 
Please re-read Rule #1 of http://linux.yyz.us/patch-format.html

Also, re-read Rule #2.  Everything in your email body before the "---" 
terminator is copied DIRECTLY into the kernel changelog.  As such,
comments like "Hello," and "List of changes in this patch:" must be
hand-edited out of your email, before applying the patch.

Please fix these problems and resubmit.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html