lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Jan 2007 12:01:46 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: David Miller <davem@...emloft.net> Cc: linux-kernel@...r.kernel.org, akpm@...l.org, deweerdt@...e.fr, netdev@...r.kernel.org, frederik.deweerdt@...il.com, shemminger@...l.org Subject: Re: + oops-in-drivers-net-shaperc.patch added to -mm tree On Sat, Jan 27, 2007 at 11:45:05AM +1100, Herbert Xu wrote: > David Miller <davem@...emloft.net> wrote: > > > > Shaper is actually OK. None of these hardware header callbacks > > should be invoked if the device is down. Yet, this is what is > > accidently being allowed in the AF_PACKET socket layer. > > Hmm, what if the device goes down after the check? In fact, the shaper device doesn't even seem to take a ref count of the device it has attached to. So that device can go away at any time. What's more, there are drivers that can change hard_header at run-time (s390). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists