[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070126.191045.48529536.davem@davemloft.net>
Date: Fri, 26 Jan 2007 19:10:45 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: linux-kernel@...r.kernel.org, akpm@...l.org, deweerdt@...e.fr,
netdev@...r.kernel.org, frederik.deweerdt@...il.com,
shemminger@...l.org
Subject: Re: + oops-in-drivers-net-shaperc.patch added to -mm tree
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sat, 27 Jan 2007 11:45:05 +1100
> David Miller <davem@...emloft.net> wrote:
> >
> > Shaper is actually OK. None of these hardware header callbacks
> > should be invoked if the device is down. Yet, this is what is
> > accidently being allowed in the AF_PACKET socket layer.
>
> Hmm, what if the device goes down after the check?
For the shaper case it's OK, because once a shaper is
associated it's ->dev never goes back to NULL.
In general, yes it's a problem :-/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists