netdev - Re: [PATCH] net: Fix the fib trie iterator to work with a single entry routing tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070126.190634.85416088.davem@davemloft.net>
Date:	Fri, 26 Jan 2007 19:06:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	Robert.Olsson@...a.slu.se, netdev@...r.kernel.org,
	robert.olsson@....uu.se
Subject: Re: [PATCH] net: Fix the fib trie iterator to work with a single
 entry routing tables

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 26 Jan 2007 08:42:25 -0700

> Robert Olsson <Robert.Olsson@...a.slu.se> writes:
> 
> > David Miller writes:
> >
> >  > > Yes the case when the trie is just a single leaf got wrong with the
> >  > > iterator and your patchs cures it. I think we have a similar problem
> >  > > with /proc/net/fib_trie
> >  > 
> >  > I'm happy to review a fix for that :-)
> >  
> > When main table is just a single leaf this gets printed as belonging to the 
> > local table in /proc/net/fib_trie. A fix is below.
> 
> Good spotting.  I was happy the data was showing up, I missed we that we put
> the meta information was wrong.
> 
> Looks good to me.

To me too, applied.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html