lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jan 2007 01:00:11 +0100 From: Adrian Bunk <bunk@...sta.de> To: David Miller <davem@...emloft.net> Cc: randy.dunlap@...cle.com, akpm@...l.org, linux-kernel@...r.kernel.org, netfilter@...ts.netfilter.org, netdev@...r.kernel.org Subject: Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n) On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: > From: Adrian Bunk <bunk@...sta.de> > Date: Sun, 28 Jan 2007 23:21:37 +0100 > > > On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote: > > >... > > > net/built-in.o: In function `q931_help': > > > nf_conntrack_h323_main.c:(.text.q931_help+0x6ad): undefined reference to `ip6_route_output' > > > nf_conntrack_h323_main.c:(.text.q931_help+0x6c3): undefined reference to `ip6_route_output' > > >... > > > > You didn't send your .config, but it seems you had CONFIG_IPV6=m and > > CONFIG_NF_CONNTRACK_H323=y. > > > > In this case, the untested patch below should fix it. > > > > > ~Randy > > > > cu > > Adrian > > > > > > <-- snip --> > > > > > > CONFIG_IPV6=m, CONFIG_NF_CONNTRACK_H323=y results in a compile error. > > > > Fix this by letting NF_CONNTRACK_H323 depend on (IPV6 || IPV6=n). > > > > Signed-off-by: Adrian Bunk <bunk@...sta.de> > > Adrian is this the correct way to constrain the selection between > "n" and "m" in this kind of situation? I thought doing something > like "depends on IPV6" is sufficient to achieve that? "depends on IPV6" would fix the bug - but it would also make NF_CONNTRACK_H323 unavailable for all people without IPV6 support in their kernel. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists