netdev - Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070205.173258.102576664.davem@davemloft.net>
Date:	Mon, 05 Feb 2007 17:32:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	nhorman@...driver.com, vladislav.yasevich@...com, sri@...ibm.com,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	kaber@...eworks.de, netdev@...r.kernel.org
Subject: Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address
 Detection

From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Tue, 06 Feb 2007 10:24:05 +0900 (JST)

> > @@ -498,7 +500,8 @@ static void ndisc_send_na(struct net_device *dev, struct neighbour *neigh,
> >          msg->icmph.icmp6_unused = 0;
> >          msg->icmph.icmp6_router    = router;
> >          msg->icmph.icmp6_solicited = solicited;
> > -        msg->icmph.icmp6_override  = override;
> > +	msg->icmph.icmp6_override  = override;
> > +
> >  
> >          /* Set the target address. */
> >  	ipv6_addr_copy(&msg->target, solicited_addr);
> 
> Why do you "change" this?

He edited it, but then reverted his change but in the
process added proper tab characters :-)  It is easy
to miss things like this.

This whole file has a lot of lines lacking proper tab
characters.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html