netdev - [PATCH] NET : keep sk_backlog near sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702221550.15280.dada1@cosmosbay.com>
Date:	Thu, 22 Feb 2007 15:50:15 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: [PATCH] NET : keep sk_backlog near sk_lock

Hi David

sk_backlog is a critical field of struct sock. (known famous words)

It is (ab)used in hot paths, in particular in release_sock(), tcp_recvmsg(), 
tcp_v4_rcv(), sk_receive_skb().

It really makes sense to place it next to sk_lock, because sk_backlog is only 
used after sk_lock locked (and thus memory cache line in L1 cache). This 
should reduce cache misses and sk_lock acquisition time.

(In theory, we could only move the head pointer near sk_lock, and leaving tail 
far away, because 'tail' is normally not so hot, but keep it simple :) )

Thank you

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

View attachment "sk_backlog.patch" of type "text/plain" (1830 bytes)